[PATCH] Add FreeBSD support to sanitizers' procmaps facilities

Alexey Samsonov samsonov at google.com
Mon Mar 24 04:48:42 PDT 2014


  LGTM modulo two nits below.


================
Comment at: lib/sanitizer_common/sanitizer_procmaps_linux.cc:170
@@ +169,3 @@
+  if (!protection) protection = &dummy;
+  *protection = 0;
+#if SANITIZER_FREEBSD
----------------
Please initialize "*protection = 0" just before you calculate it (twice, both in SANITIZER_FREEBSD and in SANITIZER_LINUX section).

================
Comment at: lib/sanitizer_common/sanitizer_procmaps_linux.cc:187
@@ +186,3 @@
+    internal_snprintf(filename,
+                      Min((uptr)filename_size, (uptr)PATH_MAX),
+                      "%s", VmEntry->kve_path);
----------------
filename_size is already uptr, cast is not needed.


http://llvm-reviews.chandlerc.com/D3100



More information about the llvm-commits mailing list