[llvm] r204071 - Make DAGCombiner work on vector bitshifts with constant splat vectors.

Andrea Di Biagio andrea.dibiagio at gmail.com
Fri Mar 21 18:54:11 PDT 2014


This should now be fixed at revision 204536.

On Sat, Mar 22, 2014 at 1:10 AM, Andrea Di Biagio
<andrea.dibiagio at gmail.com> wrote:
> On Sat, Mar 22, 2014 at 12:34 AM, Matt Arsenault
> <Matthew.Arsenault at amd.com> wrote:
>> On 03/21/2014 05:22 PM, Andrea Di Biagio wrote:
>>
>> Hi Rafael and Matt,
>>
>> I have already sent a patch for review to fix this problem.
>> (Search for an email with subject: "[PATCH][DAG] Fix assertion failure
>> caused by an invalid cast in method
>> 'BuildVectorSDNode::isConstantSplat'").
>>
>> The patch I have sent for review is this one btw.
>>
> Hi Matt,
>
>> Some more testcases with more combinations of undef elements might be
>> useful, but other than that LGTM
>>
>
> Sure, here is an updated patch with more testcases.
> Please let me know if it this is ok to submit.
>
> Thanks!
> Andrea



More information about the llvm-commits mailing list