[llvm] r204431 - [Constant Hoisting] Replace the MapVector with a separate Map and Vector to keep track of constant candidates.

Juergen Ributzka juergen at apple.com
Fri Mar 21 10:56:17 PDT 2014


This isn’t about functionality (mostly). I did this mostly to separate the map and the vector, because the mapping will get invalidated when the vector gets sorted. If someone later on modifies the code and doesn’t know or missed the fact that the mapping is no longer valid, then they may use the MapVector incorrectly.

-Juergen

On Mar 21, 2014, at 2:23 AM, David Blaikie <dblaikie at gmail.com> wrote:

> I don't really understand why the MapVector wasn't sufficient - what's
> the functionality that MapVector didn't provide that you are
> leveraging from a separate Map and Vector?

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140321/1ee51157/attachment.html>


More information about the llvm-commits mailing list