[llvm] r204425 - Fix an assertion caused by using inline asm with indirect register inputs.

Kevin Qin Kevin.Qin at arm.com
Thu Mar 20 19:14:50 PDT 2014


Author: kevinqin
Date: Thu Mar 20 21:14:50 2014
New Revision: 204425

URL: http://llvm.org/viewvc/llvm-project?rev=204425&view=rev
Log:
Fix an assertion caused by using inline asm with indirect register inputs.

Added:
    llvm/trunk/test/CodeGen/ARM/inline-diagnostics.ll
Modified:
    llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp

Modified: llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp?rev=204425&r1=204424&r2=204425&view=diff
==============================================================================
--- llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp (original)
+++ llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp Thu Mar 20 21:14:50 2014
@@ -6185,7 +6185,7 @@ static void GetRegistersForValue(Selecti
       // types are identical size, use a bitcast to convert (e.g. two differing
       // vector types).
       MVT RegVT = *PhysReg.second->vt_begin();
-      if (RegVT.getSizeInBits() == OpInfo.ConstraintVT.getSizeInBits()) {
+      if (RegVT.getSizeInBits() == OpInfo.CallOperand.getValueSizeInBits()) {
         OpInfo.CallOperand = DAG.getNode(ISD::BITCAST, DL,
                                          RegVT, OpInfo.CallOperand);
         OpInfo.ConstraintVT = RegVT;

Added: llvm/trunk/test/CodeGen/ARM/inline-diagnostics.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/ARM/inline-diagnostics.ll?rev=204425&view=auto
==============================================================================
--- llvm/trunk/test/CodeGen/ARM/inline-diagnostics.ll (added)
+++ llvm/trunk/test/CodeGen/ARM/inline-diagnostics.ll Thu Mar 20 21:14:50 2014
@@ -0,0 +1,16 @@
+; RUN: not llc %s -verify-machineinstrs -mtriple=armv7-none-linux-gnu -mattr=+neon 2>&1 | FileCheck %s
+
+%struct.float4 = type { float, float, float, float }
+
+; CHECK: error: Don't know how to handle indirect register inputs yet for constraint 'w'
+define float @inline_func(float %f1, float %f2) #0 {
+  %c1 = alloca %struct.float4, align 4
+  %c2 = alloca %struct.float4, align 4
+  %c3 = alloca %struct.float4, align 4
+  call void asm sideeffect "vmul.f32 ${2:q}, ${0:q}, ${1:q}", "=*r,=*r,*w"(%struct.float4* %c1, %struct.float4* %c2, %struct.float4* %c3) #1, !srcloc !1
+  %x = getelementptr inbounds %struct.float4* %c3, i32 0, i32 0
+  %1 = load float* %x, align 4
+  ret float %1
+}
+
+!1 = metadata !{i32 271, i32 305}





More information about the llvm-commits mailing list