[PATCH] Add option to operate on symbolic links for sys::fs::remove() and sys::fs::status()
kyrtzidis at apple.com
Thu Mar 20 18:32:51 PDT 2014
On Mar 20, 2014, at 10:25 AM, Rafael Espíndola <rafael.espindola at gmail.com> wrote:
>> Yes, this seems better.
> Cool. It LGTM :-)
>> But isn’t the sys::fs::status change to allow stat’ing symlinks good in general ? Otherwise how is sys::fs::is_symlink() supposed to work, it doesn’t work currently.
> sys::fs is a bit odd. It is very llvm specific (like stating to make
> sure we cannot remove /dev/null), but is somewhat over general for
> that. I would like to make it include only the small bits that llvm
> actually uses, even if one day sys::fs is implemented on top of a
> generic, standard c++ api, that api would necessarily be much more
> complicated than sys::fs.
> So the answer is that we should remove is_symlink, since it is dead. I
> will do that in a sec.
Committed in r204422, thanks for reviewing!
More information about the llvm-commits