ZORG: Default to no submit URL

Chris Matthews chris.matthews at apple.com
Thu Mar 20 12:34:17 PDT 2014


Looks good.  

I would suggest you change the uses of 'args +=' to args.extend, just to be consistent with how it is done in the rest of the function.

for example:
 args += ['--submit', submitURL]

to:
args.extend(['--submit', submitURL])

A buildbot reload/restart will be needed for your changes to take effect.

On Mar 20, 2014, at 11:29 AM, Galina Kistanova <gkistanova at gmail.com> wrote:

> Hi Renato,
> 
> Looks fine for me. Please feel free to commit it.
> 
> Thanks
> 
> Galina
> 
> 
> On Thu, Mar 20, 2014 at 9:01 AM, Tobias Grosser <tobias at grosser.es> wrote:
> On 03/20/2014 04:59 PM, Renato Golin wrote:
> Hi Tobi,
> 
> You don't need to change PollyBuilder because it already passes
> submitURL to LNTBuilder.
> 
> New patch attached.
> 
> OK, it looks good to me then (assuming it is tested).
> 
> Thanks Renato!
> 
> Cheers
> 
> 
> 
> 
> -- 
> Thanks
> 
> Galina

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140320/56f0d0e7/attachment.html>


More information about the llvm-commits mailing list