[compiler-rt] r204299 - PGO: Split out initialization of section bounds

Duncan P. N. Exon Smith dexonsmith at apple.com
Wed Mar 19 21:22:07 PDT 2014

On 2014 Mar 19, at 21:16, Justin Bogner <mail at justinbogner.com> wrote:

> "Duncan P. N. Exon Smith" <dexonsmith at apple.com> writes:
>> PGO: Split out initialization of section bounds
>> Currently we register instrumentation data at runtime to determine the
>> bounds of the sections where the data lives.  Soon we'll implement
>> platform-specific linker magic to determine this at link time.
>> Move this logic to a separate file, so that our build system can choose
>> the correct platform-specific code.
>> No functionality change intended.
> ...
>> Added: compiler-rt/trunk/lib/profile/InstrProfilingDefault.c
> It's pretty bikeshed-y, but something like "manual" or "register" would
> be more descriptive than default, especially since this won't be the
> default on platforms where we can do better.

The other suffixes will be things like Darwin and Elf, so Manual and
Register don’t line up.  Maybe DefaultPlatform?  UnknownPlatform?  I
still like Default better than the other options, but I’m open to more
suggestions :).

More information about the llvm-commits mailing list