[PATCH] [InstCombine] Don't fold bitcast into store if it would need addrspacecast

Matt Arsenault Matthew.Arsenault at amd.com
Wed Mar 19 19:55:24 PDT 2014


On 03/19/2014 11:13 AM, Richard Osborne wrote:
> I think the address space check here is still required. It might be 
> cleaner to bailout earlier on if the cast instruction is an address 
> space cast instead of a bitcast. Is that what you had in mind?
It is. The way it's written looks confusing because it is now 
considering both the address space of the pointers, and the address 
spaces of the pointers pointed to.




More information about the llvm-commits mailing list