[PATCH] Add ARM big endian Target (armeb, thumbeb)

Christian Pirker cpirker at a-bix.com
Wed Mar 19 10:59:44 PDT 2014


Hi Tim,

This function returns the full instruction size of the fixed-up 
instruction, and is not the number of bytes to fixup.
It will be used in the next context below (line 700) to calculate the 
index of the changed byte.

Thanks,
Christian

On 03/18/14 07:54, Tim Northover wrote:
>    Hi Christian,
>
>    I only took a small look at the code so fat, but there were some actual code-changes there so we probably want some tests for them. (those fixups and the ARMISelLowering modifications in particular).
>
>    Cheers.
>
>    Tim.
>
>
> ================
> Comment at: lib/Target/ARM/MCTargetDesc/ARMAsmBackend.cpp:648
> @@ +647,3 @@
> +
> +  case FK_Data_1:
> +  case ARM::fixup_arm_thumb_bcc:
> ----------------
> Why does FK_Data_1 have 2 bytes fixup? If it's not a straight typo, it might be pointing at a bigger abuse in existing code.
>
>
> http://llvm-reviews.chandlerc.com/D3095




More information about the llvm-commits mailing list