[PATCH] Add option to operate on symbolic links for sys::fs::remove() and sys::fs::status()

Rafael EspĂ­ndola rafael.espindola at gmail.com
Tue Mar 18 16:02:16 PDT 2014


For remove, I think we can always use lstat and change

if (!S_ISREG(buf.st_mode) && !S_ISDIR(buf.st_mode))

to

if (!S_ISREG(buf.st_mode) && !S_ISDIR(buf.st_mode) && !S_ISLNK(buf.st_mode))

no?


On 17 March 2014 19:10, Argyrios Kyrtzidis <kyrtzidis at apple.com> wrote:
> Hi Rafael,
>
> The attached patch introduces a boolean option to sys::fs::remove() and sys::fs::status() to allow them to operate on a symbolic link directly (if the provided path is one).
> This is then used by LockFileManager as the patch demonstrates.
>
> Please review!
>
> -Argyrios



More information about the llvm-commits mailing list