[PATCH] memcpy lowering: use "rep movs" even when esi is used as base pointer

Rafael Ávila de Espíndola rafael.espindola at gmail.com
Tue Mar 18 10:24:29 PDT 2014


Comment at: lib/Target/X86/X86SelectionDAGInfo.cpp:226
@@ -227,2 +225,3 @@
-  SDValue InFlag(0, 0);
+  SDValue InGlue(0, 0);
Please move this past the next if, since it is not used until then. Passing it with 0 to getCopyToReg is a nop.

It would probably be better for X86rep_movs to explicitly use RCX, RDI and RSI instead of using a glue. Please add a fixme about it.


More information about the llvm-commits mailing list