[PATCH] Add FreeBSD support to sanitizers' procmaps facilities

Alexey Samsonov samsonov at google.com
Tue Mar 18 04:06:45 PDT 2014

Comment at: lib/sanitizer_common/sanitizer_procmaps_linux.cc:285
@@ -229,3 +284,3 @@
 void GetMemoryProfile(fill_profile_f cb, uptr *stats, uptr stats_size) {
   char *smaps = 0;
Viktor Kutuzov wrote:
> Alexey Samsonov wrote:
> > I doubt this function will work on FreeBSD as expected.
> I propose that we add FreeBSD support to this function in another diff addressed to a specific failure so we can be sure it works as expected.

Comment at: lib/sanitizer_common/sanitizer_procmaps_linux.cc:20
@@ +19,3 @@
+#include <unistd.h>
+#include <sys/sysctl.h>
Viktor Kutuzov wrote:
> Alexey Samsonov wrote:
> > Please sort the headers.
> That will cause compilation errors; many system headers do not respect their dependencies on FreeBSD.
OK, disregard this comment then.


More information about the llvm-commits mailing list