[PATCH] [C++11] Change the interface of getCOFF{Section, Relocation, Symbol} to make it work with range-based for loops.

Alexey Samsonov samsonov at google.com
Tue Mar 18 00:00:16 PDT 2014


  Thanks for the review!


================
Comment at: lib/Object/COFFObjectFile.cpp:889
@@ -887,3 +888,3 @@
 
-#define LLVM_COFF_SWITCH_RELOC_TYPE_NAME(enum) \
-  case COFF::enum: Res = #enum; break;
+#define LLVM_COFF_SWITCH_RELOC_TYPE_NAME(enum)                                 \
+  case COFF::enum:                                                             \
----------------
Rui Ueyama wrote:
> Can you rename "enum"? Using a keyword as a macro parameter is a bit confusing.
Done.


http://llvm-reviews.chandlerc.com/D3097

COMMIT
  http://llvm-reviews.chandlerc.com/rL204120



More information about the llvm-commits mailing list