[compiler-rt] r204079 - PGO: Statically generate data structures

Chandler Carruth chandlerc at google.com
Mon Mar 17 15:53:28 PDT 2014


On Mon, Mar 17, 2014 at 3:28 PM, Duncan P. N. Exon Smith <
dexonsmith at apple.com> wrote:

> I see
>
> #include <stdio.h>
> #include <stdlib.h>
>
> at the top of the file.  Also, it compiles without warnings for me (and it
> works for me).
>
> Maybe fputc isn’t portable?  r204084 switches to putc.  Maybe it’s more
> portable?
>

Why would it be more portable? This function was in C89, it has existed for
approximately ever. The 'putc' function seems just a confusing and broken
alternative. I see no good reason to ever use it...
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140317/7ed6e259/attachment.html>


More information about the llvm-commits mailing list