[PATCH] [C++11] Change the interface of getCOFF{Section, Relocation, Symbol} to make it work with range-based for loops.

Rui Ueyama ruiu at google.com
Mon Mar 17 13:00:42 PDT 2014


  LGTM.


================
Comment at: lib/Object/COFFObjectFile.cpp:889
@@ -887,3 +888,3 @@
 
-#define LLVM_COFF_SWITCH_RELOC_TYPE_NAME(enum) \
-  case COFF::enum: Res = #enum; break;
+#define LLVM_COFF_SWITCH_RELOC_TYPE_NAME(enum)                                 \
+  case COFF::enum:                                                             \
----------------
Can you rename "enum"? Using a keyword as a macro parameter is a bit confusing.


http://llvm-reviews.chandlerc.com/D3097

BRANCH
  svn

ARCANIST PROJECT
  llvm



More information about the llvm-commits mailing list