[PATCH] Make StringMap aware of POD types

Chandler Carruth chandlerc at google.com
Mon Mar 17 12:43:14 PDT 2014


On Mon, Mar 17, 2014 at 12:39 PM, Pete Cooper <peter_cooper at apple.com>wrote:

> Just as an aside, why have isPodLike if not to enable POD-like hackery?
>  Seems like thats all its useful for?


It is primarily an artifact of C++98 legacy, but removing it is quite
tricky.

However, the basis of my comment is that the hackery comes at a cost. There
are some cases where it makes such a huge difference that we essentially
have to use it (being able to memcpy large data structures for example). It
is not at all clear that eliminating the tombstone splatting is a
sufficient motivation, and increasingly with C++11 these should "just work"
thanks to the standard-based type traits being compiler enforced.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140317/bffcef89/attachment.html>


More information about the llvm-commits mailing list