[PATCH] Object: Provide a richer means of describing auxiliary symbols

Nico Rieck nico.rieck at gmail.com
Mon Mar 17 11:45:40 PDT 2014



================
Comment at: tools/llvm-readobj/COFFDumper.cpp:962
@@ -982,1 +961,3 @@
+        Symbol->SectionNumber != COFF::IMAGE_SYM_ABSOLUTE &&
+        Symbol->SectionNumber != COFF::IMAGE_SYM_UNDEFINED) {
       const coff_aux_function_definition *Aux;
----------------
Since these section number checks are repeated in several spots throughout LLVM, wouldn't it make sense to use a helper function for that?


http://llvm-reviews.chandlerc.com/D3092



More information about the llvm-commits mailing list