[llvm] r204028 - Consider the base pointer for setting the symbol type.

[Rafael Espindola]

Author: rafael
Date: Sun Mar 16 23:29:51 2014
New Revision: 204028

URL: http://llvm.org/viewvc/llvm-project?rev=204028&view=rev
Log:
Consider the base pointer for setting the symbol type.

This is really a consistency fix. Since given

a = b

we propagate the information, we should propagate it too given

a = b + (1 - 1)

Fixes pr19145.

Modified:
    llvm/trunk/lib/MC/ELFObjectWriter.cpp
    llvm/trunk/test/MC/ELF/offset.s

Modified: llvm/trunk/lib/MC/ELFObjectWriter.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/MC/ELFObjectWriter.cpp?rev=204028&r1=204027&r2=204028&view=diff
==============================================================================
--- llvm/trunk/lib/MC/ELFObjectWriter.cpp (original)
+++ llvm/trunk/lib/MC/ELFObjectWriter.cpp Sun Mar 16 23:29:51 2014
@@ -580,8 +580,9 @@ void ELFObjectWriter::WriteSymbol(MCData
                                   ELFSymbolData &MSD,
                                   const MCAsmLayout &Layout) {
   MCSymbolData &OrigData = *MSD.SymbolData;
-  MCSymbolData &Data =
-    Layout.getAssembler().getSymbolData(OrigData.getSymbol().AliasedSymbol());
+  const MCSymbol *Base = OrigData.getSymbol().getBaseSymbol(Layout);
+  const MCSymbolData &Data =
+      Base ? Layout.getAssembler().getSymbolData(*Base) : OrigData;
 
   bool IsReserved = Data.isCommon() || Data.getSymbol().isAbsolute() ||
     Data.getSymbol().isVariable();

Modified: llvm/trunk/test/MC/ELF/offset.s
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/MC/ELF/offset.s?rev=204028&r1=204027&r2=204028&view=diff
==============================================================================
--- llvm/trunk/test/MC/ELF/offset.s (original)
+++ llvm/trunk/test/MC/ELF/offset.s Sun Mar 16 23:29:51 2014
@@ -6,6 +6,7 @@
         .data
         .globl	sym_a
         .byte 42
+        .type sym_a, @object
 sym_a:
 
 // CHECK:       Symbol {
@@ -13,7 +14,7 @@ sym_a:
 // CHECK-NEXT:    Value: 0x1
 // CHECK-NEXT:    Size: 0
 // CHECK-NEXT:    Binding: Global
-// CHECK-NEXT:    Type: None
+// CHECK-NEXT:    Type: Object
 // CHECK-NEXT:    Other: 0
 // CHECK-NEXT:    Section: .data
 // CHECK-NEXT:  }
@@ -28,7 +29,7 @@ sym_c = sym_a
 // CHECK-NEXT:    Value: 0x1
 // CHECK-NEXT:    Size: 0
 // CHECK-NEXT:    Binding: Global
-// CHECK-NEXT:    Type: None
+// CHECK-NEXT:    Type: Object
 // CHECK-NEXT:    Other: 0
 // CHECK-NEXT:    Section: .data
 // CHECK-NEXT:  }
@@ -40,7 +41,7 @@ sym_d = sym_a + 1
 // CHECK-NEXT:    Value: 0x2
 // CHECK-NEXT:    Size: 0
 // CHECK-NEXT:    Binding: Global
-// CHECK-NEXT:    Type: None
+// CHECK-NEXT:    Type: Object
 // CHECK-NEXT:    Other: 0
 // CHECK-NEXT:    Section: .data
 // CHECK-NEXT:  }
@@ -52,7 +53,20 @@ sym_e = sym_a + (sym_b - sym_a) * 3
 // CHECK-NEXT:    Value: 0xD
 // CHECK-NEXT:    Size: 0
 // CHECK-NEXT:    Binding: Global
-// CHECK-NEXT:    Type: None
+// CHECK-NEXT:    Type: Object
+// CHECK-NEXT:    Other: 0
+// CHECK-NEXT:    Section: .data
+// CHECK-NEXT:  }
+
+
+        .globl sym_f
+sym_f = sym_a + (1 - 1)
+// CHECK:       Symbol {
+// CHECK:         Name: sym_f
+// CHECK-NEXT:    Value: 0x1
+// CHECK-NEXT:    Size: 0
+// CHECK-NEXT:    Binding: Global
+// CHECK-NEXT:    Type: Object
 // CHECK-NEXT:    Other: 0
 // CHECK-NEXT:    Section: .data
 // CHECK-NEXT:  }