[llvm] r203939 - x86: NFC: Make getCallPreservedMask() more similar to getCalleeSavedRegs()

Chris Lattner clattner at apple.com
Fri Mar 14 22:58:31 PDT 2014

On Mar 14, 2014, at 10:31 AM, Eric Christopher <echristo at gmail.com> wrote:

> On Fri, Mar 14, 2014 at 10:30 AM, Duncan P. N. Exon Smith
> <dexonsmith at apple.com> wrote:
>> On Mar 14, 2014, at 10:28 AM, Eric Christopher <echristo at gmail.com> wrote:
>>> ... NFC?
>> No Functionality Change.  Is that ambiguous with Not For Commit?
> Honestly it's that I didn't get anything the first time there... so I
> was confused if it was some new project I'd missed ;)

This is "my fault".  My style when making major architecture changes is to refactor the world with behavior preserving patches, then drop in a simple change once the stage is set for it.

When working on an internal project, I've been doing a lot of this, and got tired of writing "no functionality change" (i.e., "don't attack me for not including a testcases :) and started contracting it as NFC.


More information about the llvm-commits mailing list