[llvm] r203943 - x86: Add missing break to getCallPreservedMask()

Duncan P. N. Exon Smith dexonsmith at apple.com
Fri Mar 14 09:29:21 PDT 2014

Author: dexonsmith
Date: Fri Mar 14 11:29:21 2014
New Revision: 203943

URL: http://llvm.org/viewvc/llvm-project?rev=203943&view=rev
x86: Add missing break to getCallPreservedMask()

This change brings getCallPreservedMask()'s logic in line with

While this changes the control flow slightly, the change is not
currently observable.  is64Bit must be false to get to the accidental
fallthrough, but the case that we fall into (coldcc) does nothing unless
is64Bit is true.


Modified: llvm/trunk/lib/Target/X86/X86RegisterInfo.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86RegisterInfo.cpp?rev=203943&r1=203942&r2=203943&view=diff
--- llvm/trunk/lib/Target/X86/X86RegisterInfo.cpp (original)
+++ llvm/trunk/lib/Target/X86/X86RegisterInfo.cpp Fri Mar 14 11:29:21 2014
@@ -316,6 +316,7 @@ X86RegisterInfo::getCallPreservedMask(Ca
       return CSR_64_Intel_OCL_BI_AVX_RegMask;
     if (!HasAVX && !IsWin64 && Is64Bit)
       return CSR_64_Intel_OCL_BI_RegMask;
+    break;
   case CallingConv::Cold:
     if (Is64Bit)

More information about the llvm-commits mailing list