[patch] Remove the linker_private and linker_private_weak linkages

Rafael Espíndola rafael.espindola at gmail.com
Thu Mar 13 16:26:50 PDT 2014

On 13 March 2014 14:46, Nick Kledzik <kledzik at apple.com> wrote:
> Rafael,
> With your great changes in r201700 to automatically use ‘l’ labels in sections that need it, ripping out the linker_private* linkage types is the right thing to do.


> My only question is if someone tries to use older bitcode that uses the now obsolete linker_private linkage types, that the right thing happens.  It looks like the new bitcode reader will map it to GlobalValue::PrivateLinkage, and the changes in  r201700 will write that as ‘L’ or ‘l’ depending on the section.  Is there some scenario were older bitcode files will not create valid mach-o with this change?

If there is, it is a bug. Like we missing a section where 'l' is
needed instead of 'L'.

> Assuming there is no compatibility issue with older bitcode files, this LGTM.

Thanks! Committed as r203866.


More information about the llvm-commits mailing list