[PATCH] Added address sanitizer instrumentation for MOV and MOVAPS inline assembly instructions.

[Evgeniy Stepanov]

================
Comment at: lib/Target/X86/AsmParser/X86AsmInstrumentation.cpp:26
@@ +25,3 @@
+
+static cl::opt<bool> ClAsanInstrumentInlineAssembly(
+    "asan-instrument-inline-assembly", cl::desc("instrument inline assembly"),
----------------
Yuri Gorshenin wrote:
> Rafael Ávila de Espíndola wrote:
> > This is for initial testing and will go away in the future, right?
> Not sure. Eugene, what do you think? Are we going to get rid of such flags, for instance when function attributes will be exposed to MCAsmParser?
> 
We may keep it for emergency disabling of asm instrumentation, just in case. Normally, it should not be needed, the decision to instrumented would be made based on sanitize_address function attribute and the blacklist.

In fact, a clang-level switch to disable asm instrumentation would be better, something like -f(no-)sanitize-asm. I don't see a good way to pass such setting down here though.


http://llvm-reviews.chandlerc.com/D2881

BRANCH
  asan-disas

ARCANIST PROJECT
  llvm