[llvm] r203682 - [X86] Set the scheduling resources of some of the FPStack instructions.

[Quentin Colombet]

Hi Eric,

I did not expect any performance changes and honestly, I haven’t measured.
This patch was more a “hey, we are missing obvious scheduling resources here!”

I hope that’s fine.

Thanks,
-Quentin

On Mar 12, 2014, at 1:50 PM, Eric Christopher <echristo at gmail.com> wrote:

> Any performance changes? :)
> 
> -eric
> 
> On Wed, Mar 12, 2014 at 10:33 AM, Quentin Colombet <qcolombet at apple.com> wrote:
>> Author: qcolombet
>> Date: Wed Mar 12 12:33:42 2014
>> New Revision: 203682
>> 
>> URL: http://llvm.org/viewvc/llvm-project?rev=203682&view=rev
>> Log:
>> [X86] Set the scheduling resources of some of the FPStack instructions.
>> This is related to <rdar://problem/15607571>.
>> 
>> Modified:
>>    llvm/trunk/lib/Target/X86/X86InstrFPStack.td
>> 
>> Modified: llvm/trunk/lib/Target/X86/X86InstrFPStack.td
>> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86InstrFPStack.td?rev=203682&r1=203681&r2=203682&view=diff
>> ==============================================================================
>> --- llvm/trunk/lib/Target/X86/X86InstrFPStack.td (original)
>> +++ llvm/trunk/lib/Target/X86/X86InstrFPStack.td Wed Mar 12 12:33:42 2014
>> @@ -206,17 +206,26 @@ def _FI32m  : FPI<0xDA, fp, (outs), (ins
>> }
>> 
>> let Defs = [FPSW] in {
>> +// FPBinary_rr just defines pseudo-instructions, no need to set a scheduling
>> +// resources.
>> defm ADD : FPBinary_rr<fadd>;
>> defm SUB : FPBinary_rr<fsub>;
>> defm MUL : FPBinary_rr<fmul>;
>> defm DIV : FPBinary_rr<fdiv>;
>> +// Sets the scheduling resources for the actual NAME#_F<size>m defintions.
>> +let SchedRW = [WriteFAddLd] in {
>> defm ADD : FPBinary<fadd, MRM0m, "add">;
>> defm SUB : FPBinary<fsub, MRM4m, "sub">;
>> defm SUBR: FPBinary<fsub ,MRM5m, "subr">;
>> +}
>> +let SchedRW = [WriteFMulLd] in {
>> defm MUL : FPBinary<fmul, MRM1m, "mul">;
>> +}
>> +let SchedRW = [WriteFDivLd] in {
>> defm DIV : FPBinary<fdiv, MRM6m, "div">;
>> defm DIVR: FPBinary<fdiv, MRM7m, "divr">;
>> }
>> +}
>> 
>> class FPST0rInst<Format fp, string asm>
>>   : FPI<0xD8, fp, (outs), (ins RST:$op), asm>;
>> @@ -228,6 +237,7 @@ class FPrST0PInst<Format fp, string asm>
>> // NOTE: GAS and apparently all other AT&T style assemblers have a broken notion
>> // of some of the 'reverse' forms of the fsub and fdiv instructions.  As such,
>> // we have to put some 'r's in and take them out of weird places.
>> +let SchedRW = [WriteFAdd] in {
>> def ADD_FST0r   : FPST0rInst <MRM0r, "fadd\t$op">;
>> def ADD_FrST0   : FPrST0Inst <MRM0r, "fadd\t{%st(0), $op|$op, st(0)}">;
>> def ADD_FPrST0  : FPrST0PInst<MRM0r, "faddp\t$op">;
>> @@ -237,15 +247,20 @@ def SUB_FPrST0  : FPrST0PInst<MRM5r, "fs
>> def SUB_FST0r   : FPST0rInst <MRM4r, "fsub\t$op">;
>> def SUBR_FrST0  : FPrST0Inst <MRM4r, "fsub{|r}\t{%st(0), $op|$op, st(0)}">;
>> def SUBR_FPrST0 : FPrST0PInst<MRM4r, "fsub{|r}p\t$op">;
>> +} // SchedRW
>> +let SchedRW = [WriteFMul] in {
>> def MUL_FST0r   : FPST0rInst <MRM1r, "fmul\t$op">;
>> def MUL_FrST0   : FPrST0Inst <MRM1r, "fmul\t{%st(0), $op|$op, st(0)}">;
>> def MUL_FPrST0  : FPrST0PInst<MRM1r, "fmulp\t$op">;
>> +} // SchedRW
>> +let SchedRW = [WriteFDiv] in {
>> def DIVR_FST0r  : FPST0rInst <MRM7r, "fdivr\t$op">;
>> def DIV_FrST0   : FPrST0Inst <MRM7r, "fdiv{r}\t{%st(0), $op|$op, st(0)}">;
>> def DIV_FPrST0  : FPrST0PInst<MRM7r, "fdiv{r}p\t$op">;
>> def DIV_FST0r   : FPST0rInst <MRM6r, "fdiv\t$op">;
>> def DIVR_FrST0  : FPrST0Inst <MRM6r, "fdiv{|r}\t{%st(0), $op|$op, st(0)}">;
>> def DIVR_FPrST0 : FPrST0PInst<MRM6r, "fdiv{|r}p\t$op">;
>> +} // SchedRW
>> 
>> def COM_FST0r   : FPST0rInst <MRM2r, "fcom\t$op">;
>> def COMP_FST0r  : FPST0rInst <MRM3r, "fcomp\t$op">;
>> @@ -264,7 +279,9 @@ def _F     : FPI<0xD9, fp, (outs), (ins)
>> let Defs = [FPSW] in {
>> defm CHS : FPUnary<fneg, MRM_E0, "fchs">;
>> defm ABS : FPUnary<fabs, MRM_E1, "fabs">;
>> +let SchedRW = [WriteFSqrt] in {
>> defm SQRT: FPUnary<fsqrt,MRM_FA, "fsqrt">;
>> +}
>> defm SIN : FPUnary<fsin, MRM_FE, "fsin">;
>> defm COS : FPUnary<fcos, MRM_FF, "fcos">;
>> 
>> 
>> 
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140313/1c40d8c7/attachment.html>