[PATCH] Fix SROA creating invalid bitcasts between address spaces

[Tom Stellard]

On Fri, Feb 28, 2014 at 01:07:29PM -0800, Chandler Carruth wrote:
> On Fri, Feb 28, 2014 at 12:57 PM, Tom Stellard <tom at stellard.net> wrote:
> 
> > Hi Chandler,
> >
> > Do you approve of merging r202247:
> >
> > [SROA] Teach SROA how to handle pointers from address spaces other than
> > the default.
> >
> > to the 3.4 branch?
> >
> 
> I have no problems merging this into the branch -- it seems particularly
> low cost as the folks working to do our first point release are impacted by
> this and want it in the branch.
> 
> However, note that this will be somewhat expensive to merge, requiring
> several of the refactorings that preceded it. I'm unlikely to have a lot of
> time to help with merging either.... =/ Let me know if you hit some
> roadblock with it.
>

Hi Chandler,

I attempted to port this patch to the 3.4 branch, attached is the result.  All
the tests pass, but I'm not sure if it is correct, can you take a look?

I looked at the refactorings which preceded this patch, and I think they
might be a little too invasive for a point release, so if my patch is
not correct and it can't be fixed without pulling in the refactoring,
then we may have to leave this fix out.

-Tom

> 
> >
> > Thanks,
> > Tom
> >
> > On Wed, Feb 26, 2014 at 01:46:49PM -0800, Matt Arsenault wrote:
> > >
> > > On Feb 26, 2014, at 1:33 PM, Tom Stellard <tom at stellard.net> wrote:
> > >
> > > > On Wed, Feb 26, 2014 at 11:48:38AM -0800, Matt Arsenault wrote:
> > > >>
> > > >>  Can we get this into the 3.4.1 branch?
> > > >>
> > > >
> > > > Which commit number is it?
> > > >
> > > > -Tom
> > > >
> > >
> > > r202247
> > >
> > > >> http://llvm-reviews.chandlerc.com/D1764
> > > >> _______________________________________________
> > > >> llvm-commits mailing list
> > > >> llvm-commits at cs.uiuc.edu
> > > >> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
> > > > _______________________________________________
> > > > llvm-commits mailing list
> > > > llvm-commits at cs.uiuc.edu
> > > > http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
> > >
> > _______________________________________________
> > llvm-commits mailing list
> > llvm-commits at cs.uiuc.edu
> > http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
> >
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Merging-r202247.patch
Type: text/x-diff
Size: 12701 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140313/c5e86c7a/attachment.patch>