[PATCH] Added address sanitizer instrumentation for MOV and MOVAPS inline assembly instructions.

[Rafael Ávila de Espíndola]

  eugenis' LGTM should be sufficient for the instrumentation itself.

  I only have a few more nits.


================
Comment at: lib/Target/X86/AsmParser/X86AsmInstrumentation.h:38
@@ +37,3 @@
+protected:
+  friend X86AsmInstrumentation *
+  CreateX86AsmInstrumentation(MCSubtargetInfo &STI);
----------------
Why not just make the constructor public?

================
Comment at: lib/Target/X86/AsmParser/X86AsmInstrumentation.cpp:26
@@ +25,3 @@
+
+static cl::opt<bool> ClAsanInstrumentInlineAssembly(
+    "asan-instrument-inline-assembly", cl::desc("instrument inline assembly"),
----------------
This is for initial testing and will go away in the future, right?

================
Comment at: lib/Target/X86/AsmParser/X86AsmInstrumentation.h:33
@@ +32,3 @@
+  // instruction is sent to Out.
+  virtual void InstrumentInstruction(
+      const MCInst &Inst, SmallVectorImpl<MCParsedAsmOperand *> &Operands,
----------------
Please move this out of line so that we get a strong vtable.


http://llvm-reviews.chandlerc.com/D2881

BRANCH
  asan-disas

ARCANIST PROJECT
  llvm