[PATCH] [C++11] Introduce ObjectFile::sections().

Alexey Samsonov samsonov at google.com
Thu Mar 13 06:58:06 PDT 2014



================
Comment at: lib/DebugInfo/DWARFContext.cpp:608
@@ -607,7 +607,3 @@
 
-DWARFContextInMemory::DWARFContextInMemory(object::ObjectFile *Obj) :
-  IsLittleEndian(Obj->isLittleEndian()),
-  AddressSize(Obj->getBytesInAddress()) {
-  for (object::section_iterator i = Obj->section_begin(),
-                                e = Obj->section_end();
-       i != e; ++i) {
+DWARFContextInMemory::DWARFContextInMemory(object::ObjectFile *Obj)
+    : IsLittleEndian(Obj->isLittleEndian()),
----------------
Rafael Ávila de Espíndola wrote:
> Unrelated change?
Nope, just a formatting fix.

================
Comment at: lib/MC/MCObjectDisassembler.cpp:91
@@ +90,3 @@
+  for (const SectionRef &Section : Obj.sections()) {
+    bool isText; Section.isText(isText);
+    bool isData; Section.isData(isData);
----------------
Rafael Ávila de Espíndola wrote:
> Newline after the ;
> In fact, please git-clang-format the patch :-)
Done


http://llvm-reviews.chandlerc.com/D3069

BRANCH
  svn

ARCANIST PROJECT
  llvm



More information about the llvm-commits mailing list