[compiler-rt] r203113 - [CMake] Build compiler-rt libraries with -Wall

[Timur Iskhodzhanov]

Confirmed, thanks!

2014-03-13 15:37 GMT+04:00 Alexey Samsonov <samsonov at google.com>:
> Should be fixed by r203786.
>
>
> On Wed, Mar 12, 2014 at 6:33 PM, Timur Iskhodzhanov <timurrrr at google.com>
> wrote:
>>
>> FTR, this has implicitly enabled /W4 in our Windows build.
>> W4 is a super-pedantic warning level, so we should really use /W3 (or
>> -W3) on Windows.
>>
>> 2014-03-06 16:25 GMT+04:00 Alexey Samsonov <samsonov at google.com>:
>> > Author: samsonov
>> > Date: Thu Mar  6 06:25:02 2014
>> > New Revision: 203113
>> >
>> > URL: http://llvm.org/viewvc/llvm-project?rev=203113&view=rev
>> > Log:
>> > [CMake] Build compiler-rt libraries with -Wall
>> >
>> > Modified:
>> >     compiler-rt/trunk/CMakeLists.txt
>> >     compiler-rt/trunk/cmake/config-ix.cmake
>> >
>> > Modified: compiler-rt/trunk/CMakeLists.txt
>> > URL:
>> > http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/CMakeLists.txt?rev=203113&r1=203112&r2=203113&view=diff
>> >
>> > ==============================================================================
>> > --- compiler-rt/trunk/CMakeLists.txt (original)
>> > +++ compiler-rt/trunk/CMakeLists.txt Thu Mar  6 06:25:02 2014
>> > @@ -235,6 +235,7 @@ pythonize_bool(COMPILER_RT_DEBUG)
>> >  #================================
>> >  include(config-ix)
>> >
>> > +add_definitions_if(COMPILER_RT_HAS_WALL_FLAG -Wall)
>> >  if(COMPILER_RT_ENABLE_WERROR)
>> >    add_definitions_if(COMPILER_RT_HAS_WERROR_FLAG -Werror)
>> >    add_definitions_if(COMPILER_RT_HAS_WX_FLAG /WX)
>> >
>> > Modified: compiler-rt/trunk/cmake/config-ix.cmake
>> > URL:
>> > http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/cmake/config-ix.cmake?rev=203113&r1=203112&r2=203113&view=diff
>> >
>> > ==============================================================================
>> > --- compiler-rt/trunk/cmake/config-ix.cmake (original)
>> > +++ compiler-rt/trunk/cmake/config-ix.cmake Thu Mar  6 06:25:02 2014
>> > @@ -26,6 +26,7 @@ check_cxx_compiler_flag(-g COMPILER_RT_H
>> >  check_cxx_compiler_flag(/Zi COMPILER_RT_HAS_Zi_FLAG)
>> >
>> >  # Warnings.
>> > +check_cxx_compiler_flag(-Wall COMPILER_RT_HAS_WALL_FLAG)
>> >  check_cxx_compiler_flag(-Werror COMPILER_RT_HAS_WERROR_FLAG)
>> >  check_cxx_compiler_flag("-Werror -Wframe-larger-than=512"
>> > COMPILER_RT_HAS_WFRAME_LARGER_THAN_FLAG)
>> >  check_cxx_compiler_flag("-Werror -Wglobal-constructors"
>> > COMPILER_RT_HAS_WGLOBAL_CONSTRUCTORS_FLAG)
>> >
>> >
>> > _______________________________________________
>> > llvm-commits mailing list
>> > llvm-commits at cs.uiuc.edu
>> > http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
>
>
>
> --
> Alexey Samsonov, MSK