[lld] r203731 - [ELF] Fix MSVC warning on conversion from enum to bool.

[Shankar Easwaran]

Thanks for fixing it.

On 3/12/2014 6:04 PM, Rui Ueyama wrote:
> Author: ruiu
> Date: Wed Mar 12 18:04:27 2014
> New Revision: 203731
>
> URL: http://llvm.org/viewvc/llvm-project?rev=203731&view=rev
> Log:
> [ELF] Fix MSVC warning on conversion from enum to bool.
>
> This function returns a boolean value, so returning STT_COMMON does not
> make sense.
>
> Modified:
>      lld/trunk/lib/ReaderWriter/ELF/Hexagon/HexagonELFFile.h
>
> Modified: lld/trunk/lib/ReaderWriter/ELF/Hexagon/HexagonELFFile.h
> URL: http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/ELF/Hexagon/HexagonELFFile.h?rev=203731&r1=203730&r2=203731&view=diff
> ==============================================================================
> --- lld/trunk/lib/ReaderWriter/ELF/Hexagon/HexagonELFFile.h (original)
> +++ lld/trunk/lib/ReaderWriter/ELF/Hexagon/HexagonELFFile.h Wed Mar 12 18:04:27 2014
> @@ -162,8 +162,7 @@ public:
>       case llvm::ELF::SHN_HEXAGON_SCOMMON_2:
>       case llvm::ELF::SHN_HEXAGON_SCOMMON_4:
>       case llvm::ELF::SHN_HEXAGON_SCOMMON_8:
> -      return llvm::ELF::STT_COMMON;
> -
> +      return true;
>       default:
>         break;
>       }
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
>


-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by the Linux Foundation