[llvm] r203726 - MCDwarf: Invert the Section+CU->LineEntries mapping so the CU is the primary dimension
David Blaikie
dblaikie at gmail.com
Wed Mar 12 15:28:57 PDT 2014
Author: dblaikie
Date: Wed Mar 12 17:28:56 2014
New Revision: 203726
URL: http://llvm.org/viewvc/llvm-project?rev=203726&view=rev
Log:
MCDwarf: Invert the Section+CU->LineEntries mapping so the CU is the primary dimension
This makes the mapping consistent with other CU->X mappings in the
MCContext, helping pave the way to refactor all these values into a
single data structure per CU and thus a single map.
I haven't renamed the data structure as that would make the patch churn
even higher (the MCLineSection name no longer makes sense, as this
structure now contains lines for multiple sections covered by a single
CU, rather than lines for a single section in multiple CUs) and further
refactorings will follow that may remove this type entirely.
For convenience, I also gave the MCLineSection value semantics so we
didn't have to do the lazy construction, manual delete, etc.
(& for those playing at home, refactoring the line printing into a
single data structure will eventually alow that data structure to be
reused to own the debug_line.dwo line table used for type unit file name
resolution)
Modified:
llvm/trunk/include/llvm/MC/MCContext.h
llvm/trunk/include/llvm/MC/MCDwarf.h
llvm/trunk/lib/MC/MCContext.cpp
llvm/trunk/lib/MC/MCDwarf.cpp
Modified: llvm/trunk/include/llvm/MC/MCContext.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/MC/MCContext.h?rev=203726&r1=203725&r2=203726&view=diff
==============================================================================
--- llvm/trunk/include/llvm/MC/MCContext.h (original)
+++ llvm/trunk/include/llvm/MC/MCContext.h Wed Mar 12 17:28:56 2014
@@ -148,10 +148,7 @@ namespace llvm {
/// The dwarf line information from the .loc directives for the sections
/// with assembled machine instructions have after seeing .loc directives.
- DenseMap<const MCSection *, MCLineSection *> MCLineSections;
- /// We need a deterministic iteration order, so we remember the order
- /// the elements were added.
- std::vector<const MCSection *> MCLineSectionOrder;
+ std::map<unsigned, MCLineSection> MCLineSections;
/// The Compile Unit ID that we are currently processing.
unsigned DwarfCompileUnitID;
/// The line table start symbol for each Compile Unit.
@@ -316,16 +313,11 @@ namespace llvm {
return MCDwarfDirsCUMap[CUID];
}
- const DenseMap<const MCSection *, MCLineSection *>
- &getMCLineSections() const {
+ const std::map<unsigned, MCLineSection> &getMCLineSections() const {
return MCLineSections;
}
- const std::vector<const MCSection *> &getMCLineSectionOrder() const {
- return MCLineSectionOrder;
- }
- void addMCLineSection(const MCSection *Sec, MCLineSection *Line) {
- MCLineSections[Sec] = Line;
- MCLineSectionOrder.push_back(Sec);
+ std::map<unsigned, MCLineSection> &getMCLineSections() {
+ return MCLineSections;
}
unsigned getDwarfCompileUnitID() {
return DwarfCompileUnitID;
Modified: llvm/trunk/include/llvm/MC/MCDwarf.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/MC/MCDwarf.h?rev=203726&r1=203725&r2=203726&view=diff
==============================================================================
--- llvm/trunk/include/llvm/MC/MCDwarf.h (original)
+++ llvm/trunk/include/llvm/MC/MCDwarf.h Wed Mar 12 17:28:56 2014
@@ -16,6 +16,7 @@
#define LLVM_MC_MCDWARF_H
#include "llvm/ADT/StringRef.h"
+#include "llvm/ADT/MapVector.h"
#include "llvm/Support/Compiler.h"
#include "llvm/Support/Dwarf.h"
#include "llvm/Support/raw_ostream.h"
@@ -172,45 +173,29 @@ public:
};
/// MCLineSection - Instances of this class represent the line information
-/// for a section where machine instructions have been assembled after seeing
+/// for a compile unit where machine instructions have been assembled after seeing
/// .loc directives. This is the information used to build the dwarf line
/// table for a section.
class MCLineSection {
-
-private:
- MCLineSection(const MCLineSection &) LLVM_DELETED_FUNCTION;
- void operator=(const MCLineSection &) LLVM_DELETED_FUNCTION;
-
public:
- // Constructor to create an MCLineSection with an empty MCLineEntries
- // vector.
- MCLineSection() {}
-
// addLineEntry - adds an entry to this MCLineSection's line entries
- void addLineEntry(const MCLineEntry &LineEntry, unsigned CUID) {
- MCLineDivisions[CUID].push_back(LineEntry);
+ void addLineEntry(const MCLineEntry &LineEntry, const MCSection *Sec) {
+ MCLineDivisions[Sec].push_back(LineEntry);
}
typedef std::vector<MCLineEntry> MCLineEntryCollection;
typedef MCLineEntryCollection::iterator iterator;
typedef MCLineEntryCollection::const_iterator const_iterator;
- typedef std::map<unsigned, MCLineEntryCollection> MCLineDivisionMap;
+ typedef MapVector<const MCSection *, MCLineEntryCollection> MCLineDivisionMap;
private:
- // A collection of MCLineEntry for each Compile Unit ID.
+ // A collection of MCLineEntry for each section.
MCLineDivisionMap MCLineDivisions;
public:
- // Returns whether MCLineSection contains entries for a given Compile
- // Unit ID.
- bool containEntriesForID(unsigned CUID) const {
- return MCLineDivisions.count(CUID);
- }
// Returns the collection of MCLineEntry for a given Compile Unit ID.
- const MCLineEntryCollection &getMCLineEntries(unsigned CUID) const {
- MCLineDivisionMap::const_iterator CIter = MCLineDivisions.find(CUID);
- assert(CIter != MCLineDivisions.end());
- return CIter->second;
+ const MCLineDivisionMap &getMCLineEntries() const {
+ return MCLineDivisions;
}
};
Modified: llvm/trunk/lib/MC/MCContext.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/MC/MCContext.cpp?rev=203726&r1=203725&r2=203726&view=diff
==============================================================================
--- llvm/trunk/lib/MC/MCContext.cpp (original)
+++ llvm/trunk/lib/MC/MCContext.cpp Wed Mar 12 17:28:56 2014
@@ -89,7 +89,6 @@ void MCContext::reset() {
MCGenDwarfLabelEntries.clear();
DwarfDebugFlags = StringRef();
MCLineSections.clear();
- MCLineSectionOrder.clear();
DwarfCompileUnitID = 0;
MCLineTableSymbols.clear();
CurrentDwarfLoc = MCDwarfLoc(0,0,0,DWARF2_FLAG_IS_STMT,0,0);
Modified: llvm/trunk/lib/MC/MCDwarf.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/MC/MCDwarf.cpp?rev=203726&r1=203725&r2=203726&view=diff
==============================================================================
--- llvm/trunk/lib/MC/MCDwarf.cpp (original)
+++ llvm/trunk/lib/MC/MCDwarf.cpp Wed Mar 12 17:28:56 2014
@@ -80,23 +80,10 @@ void MCLineEntry::Make(MCStreamer *MCOS,
// clear DwarfLocSeen saying the current .loc info is now used.
MCOS->getContext().ClearDwarfLocSeen();
- // Get the MCLineSection for this section, if one does not exist for this
- // section create it.
- const DenseMap<const MCSection *, MCLineSection *> &MCLineSections =
- MCOS->getContext().getMCLineSections();
- MCLineSection *LineSection = MCLineSections.lookup(Section);
- if (!LineSection) {
- // Create a new MCLineSection. This will be deleted after the dwarf line
- // table is created using it by iterating through the MCLineSections
- // DenseMap.
- LineSection = new MCLineSection;
- // Save a pointer to the new LineSection into the MCLineSections DenseMap.
- MCOS->getContext().addMCLineSection(Section, LineSection);
- }
-
// Add the line entry to this section's entries.
- LineSection->addLineEntry(LineEntry,
- MCOS->getContext().getDwarfCompileUnitID());
+ MCOS->getContext()
+ .getMCLineSections()[MCOS->getContext().getDwarfCompileUnitID()]
+ .addLineEntry(LineEntry, Section);
}
//
@@ -126,12 +113,8 @@ static inline const MCExpr *MakeStartMin
//
static inline void EmitDwarfLineTable(MCStreamer *MCOS,
const MCSection *Section,
- const MCLineSection *LineSection,
+ const MCLineSection::MCLineEntryCollection &LineEntries,
unsigned CUID) {
- // This LineSection does not contain any LineEntry for the given Compile Unit.
- if (!LineSection->containEntriesForID(CUID))
- return;
-
unsigned FileNum = 1;
unsigned LastLine = 1;
unsigned Column = 0;
@@ -141,9 +124,9 @@ static inline void EmitDwarfLineTable(MC
MCSymbol *LastLabel = NULL;
// Loop through each MCLineEntry and encode the dwarf line number table.
- for (MCLineSection::const_iterator
- it = LineSection->getMCLineEntries(CUID).begin(),
- ie = LineSection->getMCLineEntries(CUID).end(); it != ie; ++it) {
+ for (auto it = LineEntries.begin(),
+ ie = LineEntries.end();
+ it != ie; ++it) {
if (FileNum != it->getFileNum()) {
FileNum = it->getFileNum();
@@ -236,15 +219,6 @@ const MCSymbol *MCDwarfFileTable::Emit(M
for (unsigned Is = 1, Ie = MCLineTableSymbols.size(); Is < Ie; Is++)
EmitCU(MCOS, Is);
- // Now delete the MCLineSections that were created in MCLineEntry::Make()
- // and used to emit the line table.
- const DenseMap<const MCSection *, MCLineSection *> &MCLineSections =
- MCOS->getContext().getMCLineSections();
- for (DenseMap<const MCSection *, MCLineSection *>::const_iterator it =
- MCLineSections.begin(), ie = MCLineSections.end(); it != ie;
- ++it)
- delete it->second;
-
return LineStartSym;
}
@@ -329,20 +303,15 @@ const MCSymbol *MCDwarfFileTable::EmitCU
MCOS->EmitLabel(ProEndSym);
// Put out the line tables.
- const DenseMap<const MCSection *, MCLineSection *> &MCLineSections =
+ const std::map<unsigned, MCLineSection> &MCLineSections =
MCOS->getContext().getMCLineSections();
- const std::vector<const MCSection *> &MCLineSectionOrder =
- MCOS->getContext().getMCLineSectionOrder();
- for (std::vector<const MCSection*>::const_iterator it =
- MCLineSectionOrder.begin(), ie = MCLineSectionOrder.end(); it != ie;
- ++it) {
- const MCSection *Sec = *it;
- const MCLineSection *Line = MCLineSections.lookup(Sec);
- EmitDwarfLineTable(MCOS, Sec, Line, CUID);
- }
+ auto Iter = MCLineSections.find(CUID);
+ if (Iter != MCLineSections.end())
+ for (const auto &LineSec : Iter->second.getMCLineEntries())
+ EmitDwarfLineTable(MCOS, LineSec.first, LineSec.second, CUID);
- if (MCOS->getContext().getAsmInfo()->getLinkerRequiresNonEmptyDwarfLines()
- && MCLineSectionOrder.begin() == MCLineSectionOrder.end()) {
+ if (MCOS->getContext().getAsmInfo()->getLinkerRequiresNonEmptyDwarfLines() &&
+ Iter == MCLineSections.end()) {
// The darwin9 linker has a bug (see PR8715). For for 32-bit architectures
// it requires:
// total_length >= prologue_length + 10
More information about the llvm-commits
mailing list