[PATCH] Refactor lit.cfg to use lit.util.which

[Robinson, Paul]

Ping*2. +Daniel Dunbar as LIT owner, hope that's okay.

I want to use this as the basis for adding equivalent code
to Clang's lit.cfg which currently doesn't do the tool name
substitution thing.  We really need that for our builds.
Thanks,
--paulr

> -----Original Message-----
> From: llvm-commits-bounces at cs.uiuc.edu [mailto:llvm-commits-
> bounces at cs.uiuc.edu] On Behalf Of Robinson, Paul
> Sent: Friday, March 07, 2014 9:45 AM
> To: llvm-commits at cs.uiuc.edu commits (llvm-commits at cs.uiuc.edu)
> Subject: RE: [PATCH] Refactor lit.cfg to use lit.util.which
> 
> Ping. LIT owner? not sure who.
> --paulr
> 
> > -----Original Message-----
> > From: llvm-commits-bounces at cs.uiuc.edu [mailto:llvm-commits-
> > bounces at cs.uiuc.edu] On Behalf Of Robinson, Paul
> > Sent: Tuesday, March 04, 2014 5:01 PM
> > To: llvm-commits at cs.uiuc.edu commits (llvm-commits at cs.uiuc.edu)
> > Subject: [PATCH] Refactor lit.cfg to use lit.util.which
> >
> > llvm/test/lit.cfg was doing tool-name substitutions using PATHEXT
> > and os.path.exists().  Better to use lit.util.which, as a centralized
> > place that knows path-name quirks.
> > As a side effect, it's easy to tell if a tool doesn't exist, so I
> > removed some non-existent tools from the list.  (Possibly 'clang'
> > should also be removed? It shouldn't be used for any LLVM tests...)
> >
> > Okay to submit?
> > Thanks,
> > --paulr

-------------- next part --------------
A non-text attachment was scrubbed...
Name: llvm-lit-cfg.diff
Type: application/octet-stream
Size: 3458 bytes
Desc: llvm-lit-cfg.diff
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140312/bda35519/attachment.obj>