[PATCH] [ARM] Use DWARF register numbers for CFI directives in ELF assembly

Rafael Ávila de Espíndola rafael.espindola at gmail.com
Tue Mar 11 19:24:30 PDT 2014



================
Comment at: lib/Target/ARM/MCTargetDesc/ARMMCAsmInfo.cpp:59
@@ -57,1 +58,3 @@
+  // gas doesn't handle VFP register names in cfi directives.
+  DwarfRegNumForCFI = true;
 }
----------------
Hans Wennborg wrote:
> Saleem Abdulrasool wrote:
> > Would you mind basing this on whether or not we are using the integrated assembler?  I think that the CFI is easier to consume (as a human) when the register names are used.  If we are using an external assembler, we can fall back to the DWARF register numbers rather than the register names.
> I guess we could do that. The only downside is that it adds another test dimension :/
Please open a bug with binutils and refer to it here so that we can one day revert this.


http://llvm-reviews.chandlerc.com/D3049



More information about the llvm-commits mailing list