[PATCH] Add test for LinkModules warning on triple, modified by r203009. Datalayout is already tested.

Juergen Ributzka juergen at apple.com
Tue Mar 11 09:47:53 PDT 2014

Oops, my bad. The data layout test was still failing after the revert. Could you also apply the patch to the data layout regression test?



On Mar 11, 2014, at 5:19 AM, Rafael EspĂ­ndola <rafael.espindola at gmail.com> wrote:

> On 10 March 2014 23:38, JF Bastien <jfb at chromium.org> wrote:
>> I suggest Rafael and Juergen figure this one out, and once they do I'm glad
>> to make the change.
>> Rafael originally wrote the test with the "file empty" check, then removed
>> that check, and Juergen reverted the removal with the following message:
>> This reverts commit r202283, because when we use GuardMalloc the test will
>> fail due to additional output to std err.
> Now that I think of it, the revert in 202341 was ineffective, no? If
> malloc prints something to stdout, the test will fail whether it uses
> "count 0" or the FileCheck hack.
> FileCheck always fails on an empty input, and that is a somewhat nice
> safety feature. One option would be adding a command line option to
> allow (but not require) empty inputs.
> Another is using a small hack to ensure a never empty input. Juergen,
> would the attached patch work for you?
> Cheers,
> Rafael
> <t.patch>

More information about the llvm-commits mailing list