[PATCH] Add test for LinkModules warning on triple, modified by r203009. Datalayout is already tested.

Manman Ren manman.ren at gmail.com
Mon Mar 10 18:12:06 PDT 2014


On Mon, Mar 10, 2014 at 12:28 PM, JF Bastien <jfb at chromium.org> wrote:

>
> > I just realized that the error output is empty, so my proposed change
> will not work.
>
> It works, but it's redundant. I don't really care either way, so I checked
> in the original patch.
>
I meant  the following (what I suggested earlier) will not work because
t.a.err is empty.
> ; RUN: cat %t.a.err | FileCheck --check-prefix=WARN-A %s
> WARN-A-NOT:  WARNING: Linking two modules of different target triples:

Your checkin is fine, but I think it is possible to simplify it with
; RUN: llvm-link %s %S/Inputs/targettriple-a.ll -S 2>&1 | FileCheck %s
--check-prefix=WARN-A
; RUN: llvm-link %s %S/Inputs/targettriple-b.ll -S 2>&1 | FileCheck %s
--check-prefix=WARN-B

target triple = "e"

; WARN-A-NOT: WARNING: Linking two modules of different target triples:
; WARN-A: target triple = "e"

; WARN-B: WARNING: Linking two modules of different target triples:
; WARN-B: target triple = "e"

Cheers,
Manman
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140310/7d0ee811/attachment.html>


More information about the llvm-commits mailing list