[PATCH] Add test for LinkModules warning on triple, modified by r203009. Datalayout is already tested.

Manman Ren manman.ren at gmail.com
Mon Mar 10 10:38:00 PDT 2014


Hi Rafael,

I suggested the change because the "this is a hack" comment in the patch :]
+; RUN: cat %t.a.err | not FileCheck %s 2>&1 | FileCheck
--check-prefix=WARN-A %s
 ; this is a hack to check that llvm-link printed no warnings.
 ; WARN-A: FileCheck error: '-' is empty.

On Mon, Mar 10, 2014 at 8:42 AM, Rafael EspĂ­ndola <
rafael.espindola at gmail.com> wrote:

> >
> > ; RUN: cat %t.a.err | FileCheck --check-prefix=WARN-A %s
> > WARN-A-NOT:  WARNING: Linking two modules of different target triples:
>
> Hi Manman, this WARN-A is over the previous FileCheck run, so I don't
> think this WARN-A-NOT has any value, it is trivially true.
>

I just realized that the error output is empty, so my proposed change will
not work.

Cheers,
Manman


> Cheers,
> Rafael
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140310/136a87b8/attachment.html>


More information about the llvm-commits mailing list