[PATCH] sectiongroup support

[Michael Spencer]

  I still feel this implementation is going to slow down the linker a lot.


================
Comment at: lib/Core/SymbolTable.cpp:51
@@ +50,3 @@
+    if (atom.contentType() == DefinedAtom::typeGroupComdat) {
+      this->addGroup(atom);
+      return;
----------------
No `this->`.

================
Comment at: lib/Core/SymbolTable.cpp:300
@@ +299,3 @@
+      if (r->kindValue() == Reference::kindGroupChild)
+        this->addGroupChild(*r->target(), da);
+    }
----------------
No `this->`.

================
Comment at: lib/Core/SymbolTable.cpp:334
@@ +333,3 @@
+  // Catch an error if the user forgot to include the child in the parent.
+  if (!groupChildExistsinGroup(groupChild, groupParent)) {
+    llvm::errs() << "SymbolTable: error while merging " << name << "\n";
----------------
Shouldn't this only be checked in asserts builds?


http://llvm-reviews.chandlerc.com/D2961