[PATCH] Add CreatePointerBitCastOrAddrSpaceCast to IRBuilder and co.
qcolombet at apple.com
Thu Mar 6 14:37:27 PST 2014
So if I understood correctly, this is syntactic sugar to help spotting the places where it was likely we were not expected an addrspace to be created.
However, CreatePointerCast producing an addrspace is still a valid option.
If you believe there is a value in making such a syntactic distinction, I suggest we do a bit of a refactoring in that patch.
Let us make CreatePointerCast and co. calls CreatePointerBitCastOrAddrSpace and co.
That way, we avoid the code duplication and we still have a way to make this distinction.
What do you think?
More information about the llvm-commits