[PATCH] [RuntimeDyld] Make ObjectBuffer/ObjectFile -> ObjectImage conversion a static method.

Lang Hames lhames at gmail.com
Wed Mar 5 11:20:33 PST 2014


Hi All,

I would like to ensure that the target architecture for a
RuntimeDyldImpl instance is known at construction time. Once this is
possible, target specific logic (relocations/stub management) can be
pushed down into the target specific subclasses, rather than living in
large switch statements. This will improve both performance and
readability.

To support this work, this patch changes the way ObjectImages are
constructed from ObjectFiles and ObjectBuffers: it replaces virtual
methods on RuntimeDyldImpl with static methods on the relevant
subclasses (RuntimeDyldELF, RuntimeDyldMachO). All the information
needed to call the correct subclass method is already available at the
call sites, so we don't lose any flexibility by switching to static
methods here.

Cheers,
Lang.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: make_objimage_construction_static.patch
Type: application/octet-stream
Size: 9655 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140305/22dc3005/attachment.obj>


More information about the llvm-commits mailing list