[PATCH] Remove unnecessary variables.

David Blaikie dblaikie at gmail.com
Tue Mar 4 20:23:34 PST 2014


Looks good to me

On Tue, Mar 4, 2014 at 8:21 PM, Ahmed Charles <acharles at outlook.com> wrote:
> Hi dblaikie,
>
> Found self-hosting clang-cl on windows. :)
>
> http://llvm-reviews.chandlerc.com/D2957
>
> Files:
>   lib/Support/Windows/Process.inc
>
> Index: lib/Support/Windows/Process.inc
> ===================================================================
> --- lib/Support/Windows/Process.inc
> +++ lib/Support/Windows/Process.inc
> @@ -154,7 +154,7 @@
>  Optional<std::string> Process::GetEnv(StringRef Name) {
>    // Convert the argument to UTF-16 to pass it to _wgetenv().
>    SmallVector<wchar_t, 128> NameUTF16;
> -  if (error_code ec = windows::UTF8ToUTF16(Name, NameUTF16))
> +  if (windows::UTF8ToUTF16(Name, NameUTF16))
>      return None;
>
>    // Environment variable can be encoded in non-UTF8 encoding, and there's no
> @@ -175,7 +175,7 @@
>
>    // Convert the result from UTF-16 to UTF-8.
>    SmallVector<char, MAX_PATH> Res;
> -  if (error_code ec = windows::UTF16ToUTF8(Buf.data(), Size, Res))
> +  if (windows::UTF16ToUTF8(Buf.data(), Size, Res))
>      return None;
>    return std::string(Res.data());
>  }



More information about the llvm-commits mailing list