[PATCH] Canonicalise Windows target triple spellings

Saleem Abdulrasool abdulras at fb.com
Tue Mar 4 15:33:42 PST 2014


On Mar 4, 2014, at 1:59 PM, Chandler Carruth <chandlerc at gmail.com> wrote:

> 
> On Tue, Mar 4, 2014 at 11:53 AM, Saleem Abdulrasool <abdulras at fb.com> wrote:
> i686-pc-win32 => i686-pc-windows-msvc
> i686-pc-mingw32 => i686-pc-windows-gnu
> i686-pc-cygwin => i686-pc-windows-cygnus
> 
> I don't understand the use of 'pc' as vendor -- is this just that vendor is preserved? I would hope that the default is "unknown" much the way it is on Linux.

Yes, that is supposed to indicate that the vendor is preserved.  If you do not specify one, one is not inserted, and I have tests to ensure that.  I would love to see unknown become the default here as it is on Linux.

-- 
Saleem Abdulrasool
abdulras (at) fb (dot) com









More information about the llvm-commits mailing list