[polly] r202855 - Always name instructions

Tobias Grosser tobias at grosser.es
Tue Mar 4 07:43:57 PST 2014


Author: grosser
Date: Tue Mar  4 09:43:57 2014
New Revision: 202855

URL: http://llvm.org/viewvc/llvm-project?rev=202855&view=rev
Log:
Always name instructions

We currently need to always name instructions, as the polly test suite currently
matches for certain names. We should improve the test suite at some point.

This fixes 'make check-polly' in NDEBUG builds.

Modified:
    polly/trunk/include/polly/CodeGen/IRBuilder.h

Modified: polly/trunk/include/polly/CodeGen/IRBuilder.h
URL: http://llvm.org/viewvc/llvm-project/polly/trunk/include/polly/CodeGen/IRBuilder.h?rev=202855&r1=202854&r2=202855&view=diff
==============================================================================
--- polly/trunk/include/polly/CodeGen/IRBuilder.h (original)
+++ polly/trunk/include/polly/CodeGen/IRBuilder.h Tue Mar  4 09:43:57 2014
@@ -91,12 +91,14 @@ private:
   class LoopAnnotator *Annotator;
 };
 
-#ifdef NDEBUG
-typedef PollyBuilderInserter<false> IRInserter;
-typedef llvm::IRBuilder<false, llvm::ConstantFolder, IRInserter> PollyIRBuilder;
-#else
+// TODO: We should not name instructions in NDEBUG builds.
+//
+// We currently always name instructions, as the polly test suite currently
+// matches for certain names.
+//
+// typedef PollyBuilderInserter<false> IRInserter;
+// typedef llvm::IRBuilder<false, llvm::ConstantFolder, IRInserter> PollyIRBuilder;
 typedef PollyBuilderInserter<true> IRInserter;
 typedef llvm::IRBuilder<true, llvm::ConstantFolder, IRInserter> PollyIRBuilder;
-#endif
 }
 #endif





More information about the llvm-commits mailing list