[llvm] r202662 - Give APInt move semantics.

Benjamin Kramer benny.kra at gmail.com
Sun Mar 2 17:20:27 PST 2014


On 03.03.2014, at 01:22, Ahmed Charles <acharles at outlook.com> wrote:

> ----------------------------------------
>> Subject: [llvm] r202662 - Give APInt move semantics.
>> Date: Sun, 2 Mar 2014 20:56:28 +0000
>> To: llvm-commits at cs.uiuc.edu
>> From: benny.kra at googlemail.com
>> 
>> Author: d0k
>> Date: Sun Mar 2 14:56:28 2014
>> New Revision: 202662
>> 
>> URL: http://llvm.org/viewvc/llvm-project?rev=202662&view=rev
>> Log:
>> Give APInt move semantics.
>> 
>> The interaction between defaulted operators and move elision isn't
>> totally obvious, add a unit test so it doesn't break unintentionally.
>> 
> 
> 
> This change also seems to rely on defaulted move operations? 		 	   		  

The move operations are purely for code cleanup and performance reasons, it wouldn't hurt if MSVC doesn't implement them correctly. The unit test however verifies that the underlying object is moved instead of just copied, it's possible that a compiler that doesn't implement generation of move operations will trip over the test. In that case we have to disable the test for that specific compiler. So far all buildbots have passed the test so maybe we can get away this time.

- Ben



More information about the llvm-commits mailing list