[llvm] r202283 - Use count 0.

[Eric Christopher]

On Wed, Feb 26, 2014 at 6:30 PM, Juergen Ributzka <juergen at apple.com> wrote:
> Hi Rafael,
>
> these test are failing now when we use GuardMalloc during test runs, because it writes 4 lines of status message to stderr.
> Can we go back to the original check instead?
>

Not that it's a huge deal here, but if it becomes so in the future you
might want to do something similar to the objc4 test harness
(http://www.opensource.apple.com/source/objc4/objc4-551.1/test/test.pl?txt)
and just wrap the binaries in something that strips out the first 4
lines of output if running in guard malloc road.

I'm really not suggesting this for now, that's a lot of work for one
test and guard malloc testing is far more useful than the hack to
check for no warnings is annoying :)

-eric

> Cheers,
> Juergen
>
>
> On Feb 26, 2014, at 9:57 AM, Rafael Espindola <rafael.espindola at gmail.com> wrote:
>
>> Author: rafael
>> Date: Wed Feb 26 11:57:35 2014
>> New Revision: 202283
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=202283&view=rev
>> Log:
>> Use count 0.
>>
>> Thanks to Roman Divacky for the suggestion.
>>
>> Modified:
>>    llvm/trunk/test/Linker/datalayout.ll
>>
>> Modified: llvm/trunk/test/Linker/datalayout.ll
>> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Linker/datalayout.ll?rev=202283&r1=202282&r2=202283&view=diff
>> ==============================================================================
>> --- llvm/trunk/test/Linker/datalayout.ll (original)
>> +++ llvm/trunk/test/Linker/datalayout.ll Wed Feb 26 11:57:35 2014
>> @@ -1,5 +1,5 @@
>> ; RUN: llvm-link %s %S/Inputs/datalayout-a.ll -S -o - 2>%t.a.err | FileCheck %s
>> -; RUN: cat %t.a.err | not FileCheck %s 2>&1 | FileCheck --check-prefix=WARN-A %s
>> +; RUN: cat %t.a.err | count 0
>>
>> ; RUN: llvm-link %s %S/Inputs/datalayout-b.ll -S -o - 2>%t.b.err | FileCheck %s
>> ; RUN: cat %t.b.err | FileCheck --check-prefix=WARN-B %s
>> @@ -8,7 +8,4 @@ target datalayout = "e"
>>
>> ; CHECK: target datalayout = "e"
>>
>> -; this is a hack to check that llvm-link printed no warnings.
>> -; WARN-A: FileCheck error: '-' is empty.
>> -
>> ; WARN-B: WARNING: Linking two modules of different data layouts!
>>
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits