[llvm] r202199 - Address review comments for r202188.

[Justin Bogner]

Adrian Prantl <aprantl at apple.com> writes:
>> Isn't this what "CHECK-LABEL" is for? IIUC you can change the subprogram
>> checks to "CHECK-LABEL: DW_TAG_subprogram" and drop the CHECK-NOTs to
>> get the behaviour you want.
>
> Maybe I just find the documentation confusing, but doesn’t this:
>
>> There is no requirement that CHECK-LABEL: directives contain strings
>> that correspond to actual syntactic labels in a source or output
>> language: they must simply uniquely match a single line in the file
>> being verified.
>
> mean that each “LABEL” must be unique in the file?

Hmm, maybe. The part where it says:

> Conceptually, the presence of CHECK-LABEL divides the input stream
> into separate blocks, each of which is processed independently,
> preventing a CHECK: directive in one block matching a line in another
> block.

made me think that this could be used for things that have a recurring
divider as well. On re-reading the docs, I'm not so sure that's a valid
way to use CHECK-LABEL after all. I guess I might have been imagining
features I would like to exist.