[compiler-rt] r201916 - Revert "Replace __FUNCTION__ with __func__, the latter being standard C99/C++11."

Chandler Carruth chandlerc at google.com
Wed Feb 26 14:00:51 PST 2014


On Feb 26, 2014 1:35 PM, "Joerg Sonnenberger" <joerg at britannica.bec.de>
wrote:
>
> On Wed, Feb 26, 2014 at 01:16:30PM -0800, Chandler Carruth wrote:
> > Joerg, I see you've committed this patch without review when numerous
> > members of the project had clearly expressed disagreement with the
> > direction. It also doesn't build.
>
> I have asked for testing and the testing showed that the case I had to
> assume is problematic from the absolute lack of information works.
> Reverting a patch immediately without any information whatsoever is
> plainly just as rude.

There was a clear and expressed concern over the fundamental direction of
the patch. As such, I don't think you or anyone else needs more information
to know that it is not ready to be committed.

>
> Joerg
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140226/fbac957c/attachment.html>


More information about the llvm-commits mailing list