[compiler-rt] r201916 - Revert "Replace __FUNCTION__ with __func__, the latter being standard C99/C++11."

[Chandler Carruth]

Joerg, I see you've committed this patch without review when numerous
members of the project had clearly expressed disagreement with the
direction. It also doesn't build.

Please, *do not* do this again. Ping, hassle, get people to reply, but
there is nothing even approaching consensus about what the correct path
forward for compiler-rt is here, and the use of __FUNCTION__ is long
standing and not a regression in any way.

Please revert again immediately, and resume code review.


On Mon, Feb 24, 2014 at 2:21 AM, Joerg Sonnenberger <joerg at britannica.bec.de
> wrote:

> On Sat, Feb 22, 2014 at 03:07:10PM -0800, Richard Smith wrote:
> > I don't think this is clear at all. This feature is not in C++98, and
> we're
> > not allowing C++11 features yet.
>
> Neither is __FUNCTION__.
>
> > Even when we do, we only intend to allow
> > C++11 features that are supported by all of our supported compilers, and
> > this is not such a feature. Why should this be treated as a special case?
>
> The choice is between a completely non-standard feature with strange
> semantics and a standard feature that can be emulated easily on the
> one compiler still not supporting a 15 year old spec. Attached is a
> patch that should work for MSVC, but I can't test it.
>
> Joerg
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140226/ff23a2d6/attachment.html>