[PATCH] Debug info: Support fragmented variables.

[Eric Christopher]

On Tue, Feb 25, 2014 at 7:30 PM, David Blaikie <dblaikie at gmail.com> wrote:
>
>
>
> On Tue, Feb 25, 2014 at 7:11 PM, Eric Christopher <echristo at gmail.com>
> wrote:
>>
>>
>>   Hi Adrian,
>>
>>   This is a lot of great work, thanks!
>>
>>   I think the first question is how this is going to interact with
>> DIBuilder::createComplexVariable? I think it should just be a concatenation
>> of the two things. It looks like you have it as an instead?
>
>
> Missed a word here? ("It looks like you have it as an <thing> instead?")

So I did. I think I wanted a word and it wasn't coming to mind. We'll
say "either/or" as <thing>. :)

-eric

>
>>
>> In general, I think I like the idea that variable locations just have
>> expressions attached to them. And lacking anything else I think dwarf
>> expressions are just fine here.
>>
>>   I've got more comments on the patch itself, but let's get this out of
>> the way first.
>>
>>   -eric
>>
>> http://llvm-reviews.chandlerc.com/D2680
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>