[PATCH] Schedule discriminators pass.

Eric Christopher echristo at gmail.com
Tue Feb 25 17:29:16 PST 2014


  Comments inline.


================
Comment at: lib/CodeGen/CGDebugInfo.cpp:2581
@@ -2581,1 +2580,3 @@
+                                getColumnNumber(CurLoc),
+                                0);
   llvm::MDNode *DN = D;
----------------
This can go in before, it just means that nothing will deal with it yes? In addition, it would be good to test that nothing changes if you pass 0 here and don't actually run the pass.

================
Comment at: test/CodeGenCXX/linetable-eh.cpp:9
@@ -8,3 +8,3 @@
 // CHECK: unwind label %{{.*}}, !dbg ![[DBG1]]
-// CHECK: store i64 %{{.*}}, i64* %current_address, align 8, !dbg ![[DBG1]]
+// CHECK: store i64 %{{.*}}, i64* %current_address, align 8, !dbg ![[DBG4:.*]]
 // CHECK-NEXT: call void @llvm.dbg.declare(metadata !{{{.*}}}, metadata ![[FOUND_IT:.*]]), !dbg ![[DBG2:.*]]
----------------
This is with the pass running?


http://llvm-reviews.chandlerc.com/D2692



More information about the llvm-commits mailing list