AARCH64_BE load/store rules fix to conform to ARM ABI

Adrian Prantl aprantl at apple.com
Tue Feb 25 13:28:33 PST 2014


On Feb 25, 2014, at 9:10, Renato Golin <renato.golin at linaro.org> wrote:

> On 25 February 2014 16:59, Albrecht Kadlec <akadlec at a-bix.com> wrote:
>> there're a few misunderstandings:
> 
> I apologise.
> 
> 
>> First, I'm not Christian (and he had a reviewer explicitly asking for those
>> _related_ indentations, which brings up the question about global policy.)
> 
> This is a global policy, not sure where it is, though, or why people
> accepted white space changes alongside functionality changes.
> 

It’s over here:

http://llvm.org/docs/CodingStandards.html#golden-rule

> Our long term goal is for the entire codebase to follow the convention, but we explicitly do not want patches that do large-scale reformating of existing code. On the other hand, it is reasonable to rename the methods of a class if you’re about to change it in some other way. Just do the reformating as a separate commit from the functionality change.
> 

Submitting two patches, one that does the necessary cleanups, and one that has the actual changes should be fine.

-- adrian



More information about the llvm-commits mailing list