[PATCH] Sizes and layouts for sanitizers on FreeBSD

Evgeniy Stepanov eugenis at google.com
Tue Feb 25 03:17:17 PST 2014


  Don't you need to do anything with the includes in sanitizer_platform_limits_posix.cc?
  There is a bunch of them under #ifdef SANITIZER_LINUX, and as it is, you are missing COMPILER_ASSERT's for the struct declarations that were enabled under SANITIZER_FREEBSD, and initializers for extern declarations.


================
Comment at: lib/sanitizer_common/sanitizer_platform_limits_posix.h:103
@@ +102,3 @@
+#elif defined(__powerpc64__)
+  const unsigned struct___old_kernel_stat_sz = 0;
+#endif
----------------
No need to list all platforms, just do #ifdef (__powerpc64__) .. #else ..


http://llvm-reviews.chandlerc.com/D2831



More information about the llvm-commits mailing list