[PATCH] Adds Cortex-A53 and Cortex-A57 subtargets.

Jiangning Liu liujiangning1 at gmail.com
Mon Feb 24 21:23:38 PST 2014


  Hi Dave,

  Overall the changes look good to me, and I expect you are going to add more for forwarding and other tuning stuff.

  I think we'd better disable it first and enable it later on all at once after you complete all, and otherwise I expect some test cases added to verify the scheduling effect.

  The document you mentioned is not publicly available to everybody in community, so we should avoid mentioning it in the code.

  Thanks,
  -Jiangning


================
Comment at: lib/Target/AArch64/AArch64ScheduleA53.td:27
@@ +26,3 @@
+                       // Itineraries are queried instead.
+  let MispredictPenalty = 9; // Based on "Cortex-A53 Software Optimisation
+                             // Specification - Instruction Timings"
----------------
Could you please avoid mentioning this specific document if the people in community can't really access it?


http://llvm-reviews.chandlerc.com/D2829



More information about the llvm-commits mailing list